Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that one of the dependent jobs succeeded. #453

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Ensure that one of the dependent jobs succeeded. #453

merged 2 commits into from
Feb 20, 2024

Conversation

ksuderman
Copy link
Contributor

The tag-and-release job depends on the package-from-pr or package-from-manual jobs succeeding. However, the packaging jobs are mutually exclusive so we need to test if one, but not both, have succeeded.

See Stack Overflow

Closes #452

@ksuderman ksuderman mentioned this pull request Feb 19, 2024
Merged
nuwang
nuwang approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for this fix. Can we rerun this manually and rebuild the release history? Also, why is it missing the changelog despite --release-notes being present?

@ksuderman
Copy link
Contributor Author

No, this will only tag the latest commit/version. I have a separate script I used to tag/release previous versions. That script didn't include --generate-notes since the commit messages have been vague and consist almost entirely of "Automatic Version Bumping from X to X+1". We can regenerate them if needed though.

I'll add my tag-and-release.sh script to the repo in a separate PR.

@nuwang
Copy link
Member

nuwang commented Feb 20, 2024

So --generate-notes doesn't do the same thing as here?
image

Is there someway we can make it add the changelog? That would be perfect.

@ksuderman
Copy link
Contributor Author

ksuderman commented Feb 20, 2024 •
edited
Loading

No, it does not seem to when generated releases from past tags. See the 5.8.0 and 5.9.0 releases I just generated. Note that is just when generating release notes from previous tags/commits. It should be fine going forward.

@nuwang
Copy link
Member

nuwang commented Feb 20, 2024

Should be good to go then?

@ksuderman
Copy link
Contributor Author

I think so...

@nuwang nuwang merged commit 1b40fda into galaxyproject:master Feb 20, 2024
2 checks passed
@ksuderman ksuderman deleted the 452-tag-and-release branch February 21, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuwang nuwang nuwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Releases are not being tagged
2 participants
@ksuderman @nuwang